remote.nextstrain_dot_org: Include an explicit origin in error messages #391
+34
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, for remote origins other than the default of nextstrain.org, the error messages suggest incorrect/misleading possible solutions in the form of commands to run. Motivated by @jameshadfield's comments in Slack.¹ ¹ <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1723760025178909?thread_ts=1723701856.612259&cid=C01LCTT7JNN>
tsibley
force-pushed
the
trs/remote/origin-in-error-messages
branch
from
94a1f81
to
740b0bf
Compare
genehack
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, for remote origins other than the default of nextstrain.org, the error messages suggest incorrect/misleading possible solutions in the form of commands to run.
Motivated by @jameshadfield's comments in Slack.¹
¹ https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1723760025178909?thread_ts=1723701856.612259&cid=C01LCTT7JNN
Checklist